Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cluster resource_labels #210

Merged
merged 7 commits into from
Jul 22, 2019

Conversation

Dev25
Copy link
Contributor

@Dev25 Dev25 commented Jul 19, 2019

https://www.terraform.io/docs/providers/google/r/container_cluster.html#resource_labels

Add support for GCE resource labels, compatible with Terraform 0.12

Tested locally with an existing cluster. There is a existing PR from a few months ago #81 which more or less does the same thing, i can cherry pick those integration tests cases if preferred?

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dev25 Thanks for the contribution! Mostly looks good, but could you make sure the linters pass and add a note to the CHANGELOG?

@morgante morgante merged commit 3bb39cd into terraform-google-modules:master Jul 22, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants